Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize creation of sparrays from pdarrays #3877

Merged

Conversation

ShreyasKhandekar
Copy link
Contributor

@ShreyasKhandekar ShreyasKhandekar commented Oct 29, 2024

Used the algorithm provided by Engin to optimize the creation of sparse matrices from three pdarrays of rows, cols, and vals.

  • Testing on single and multi locale on dev cluster.

Used the algorithm provided by Engin to optimize the creation of sparse
matrices from three pdarrays of rows, cols, and vals.

Signed-off-by: Shreyas Khandekar <[email protected]>
Copy link
Contributor

@e-kayrakli e-kayrakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mostly cosmetic nits, otherwise looks good!

src/SparseMatrix.chpl Outdated Show resolved Hide resolved
src/SparseMatrix.chpl Outdated Show resolved Hide resolved
src/SparseMatrix.chpl Outdated Show resolved Hide resolved
src/SparseMatrix.chpl Show resolved Hide resolved
Signed-off-by: Shreyas Khandekar <[email protected]>
Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Shreyas.

@bmcdonald3 bmcdonald3 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into Bears-R-Us:master with commit eccf553 Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants