Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3861: Update hdf5 download link in Makefile #3862

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

stress-tess
Copy link
Member

I updated the hdf5 download link in the Makefile cause the last one was outdated. It now points here:
https://support.hdfgroup.org/releases/hdf5/v1_14/v1_14_4/downloads/

The only thing I don't love about this is the tar file has a -3 at the end, so a future update could break the link again... I could prob wildcard this part but I wanted to see what others thought

Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm OK with the 3, thanks Tess. I think, like we saw with the last link, these will all break with time, so I don't think the hardcoded 3 is a problem

@stress-tess stress-tess added this pull request to the merge queue Oct 23, 2024
Merged via the queue into Bears-R-Us:master with commit f27450c Oct 23, 2024
11 checks passed
@stress-tess stress-tess deleted the 3861_makefile_hdf5_link branch October 24, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants