Fix broken error reporting for Chapel 2.0 in register-commands.py
#3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremiah Corrado <[email protected]>
stress-tess
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
ah I'm running 2.2. no wonder I didn't see it. Thanks for finding this @drculhane and thanks for fixing it @jeremiah-corrado
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in
register-commands.py's error reporting, where the code was only working with versions of chpl >=2.1. Errors should now be reported correctly for versions 2.0 - 2.2.Thanks @drculhane for figuring out that this was an issue with the Chapel version!