Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SparseMatrixMsg to use automated registration #3832

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Refactor SparseMatrixMsg to use automated registration #3832

merged 6 commits into from
Oct 11, 2024

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Oct 9, 2024 •
edited
Loading

Refactor SparseMatrixMsg to use instantiateAndRegister.

Related changes to Sparse code:

  • rename layout enum to Layout
  • add SparseSymEntry support to st.insert
  • simplify SparseSymEntry's initializer

Improvements to function registration:

  • add support for generic enum params (useful for Layout enum)
  • add support for auto-generating argument-parsing code for any class that inherits from AbstractSymEntry
    • if the class is generic (like SparseSymEntry), each of its generic fields must have corresponding fields in the config file
  • add support for auto-generating response code for procedures that return classes that inherit from AbstractSymEntry

@jeremiah-corrado
refactor SparseMatrixMsg to use instantiateAndRegister. Add support f…
3c3133e 
…or param enums to instantiateAndRegister. Rename 'layout' to 'Layout'. Simplify SparseSymEntry initializer.

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
update special CI config files
45019bd 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
add support for auto-generating argument parsing code for any non-arr…
53d3a39 
…ay SymEntry class. Generic fields are populated using a parameter class in the config file with the same name, and same field names

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix multi-locale ambiguity error
eef2e1f 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
add support for procedures that return non-SymEntry classes (that inh…
a8f192d 
…erit from AbstractSymEntry) to registerCommand

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review October 10, 2024 18:54
stress-tess
stress-tess approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks jeremiah!

@stress-tess stress-tess added this pull request to the merge queue Oct 11, 2024
Merged via the queue into Bears-R-Us:master with commit 275b5b3 Oct 11, 2024
11 checks passed
ShreyasKhandekar
ShreyasKhandekar approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ShreyasKhandekar ShreyasKhandekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late to the party, but the changes on the sparse side look good to me :)

@jeremiah-corrado jeremiah-corrado deleted the refactor-sparse-matrix branch October 11, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreyasKhandekar ShreyasKhandekar ShreyasKhandekar approved these changes

@stress-tess stress-tess stress-tess approved these changes

@bmcdonald3 bmcdonald3 bmcdonald3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremiah-corrado @bmcdonald3 @stress-tess @ShreyasKhandekar