Fix performance regression in array transfer performance #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low-transposed Signed-off-by: Jeremiah Corrado <[email protected]>
bmcdonald3
approved these changes
Oct 7, 2024
ajpotts
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a recent regression in array transfer performance caused by an extra array copy added here.
The copy was included to ensure the array data are properly transposed on the server side following a shallow numpy transpose (where the buffer remains the same and an array-metadata flag is set to indicate that the array was transposed). The change fixed #3757, but added overhead. This PR only makes the extra copy for the shallow-transpose case, which should restore performance for the common case.