Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3714: pdarray.shape should be a tuple #3803

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Closes #3714: pdarray.shape should be a tuple #3803

merged 1 commit into from
Oct 9, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Sep 30, 2024 •
edited
Loading

This PR changes pdarray.shape to be a tuple to match numpy better:
https://numpy.org/doc/2.1/reference/generated/numpy.shape.html

Closes #3714: pdarray.shape should be a tuple

@ajpotts ajpotts marked this pull request as ready for review October 1, 2024 13:39
@ajpotts ajpotts force-pushed the 3714-pdarray.shape-should-be-a-tuple branch from a191247 to 3b3c153 Compare October 1, 2024 15:54
drculhane
drculhane approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although a strange bug is keeping me from running make test on this on my virtual machine, all of the changes look straightforward and solid, and it has passed all the checks upstream. Looks good to me.

jaketrookman
jaketrookman approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

stress-tess
stress-tess approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks!

@stress-tess stress-tess added this pull request to the merge queue Oct 9, 2024
Merged via the queue into Bears-R-Us:master with commit 5af79f8 Oct 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drculhane drculhane drculhane approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@stress-tess stress-tess stress-tess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pdarray.shape should be a tuple
4 participants
@ajpotts @stress-tess @jaketrookman @drculhane