Closes #3782: flip function to match numpy #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3782-flip-function-to-match-numpy
branch
2 times, most recently
from
97f0724 to
9e1f277
Compare
ajpotts
force-pushed
the
3782-flip-function-to-match-numpy
branch
from
9e1f277 to
4a7b6a3
Compare
|
When I download this and run pytest on test_manipulation_functions, test_flip_string fails in single dim, and both test_flip_string and test_flip_multi_dim_bool fail in multi dim. But I see that it passed all the checks, so I'm not sure what to make of this.
|
ajpotts
force-pushed
the
3782-flip-function-to-match-numpy
branch
3 times, most recently
from
70194c8 to
188e515
Compare
|
Fixed two problems likely causing it to fail locally but not in the CI:
Thanks Andy, for pointing this out. @drculhane |
|
When I download this and run pytest on test_manipulation_functions, test_flip_string fails in single dim, and both test_flip_string and test_flip_multi_dim_bool fail in multi dim. But I see that it passed all the checks, so I'm not sure what to make of this.
|
|
This is what I get. I had it sent to a text file, since these sorts of things are always long. |
stress-tess
approved these changes
Oct 4, 2024
ajpotts
force-pushed
the
3782-flip-function-to-match-numpy
branch
from
188e515 to
6d011a2
Compare
ajpotts
force-pushed
the
3782-flip-function-to-match-numpy
branch
from
1b91ab4 to
a07e845
Compare
stress-tess
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flip function to match numpy:
https://numpy.org/doc/2.1/reference/generated/numpy.flip.html
Closes #3782: flip function to match numpy