Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for running each benchmark in its own server instance #3730

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Aug 30, 2024

Add options to run_benchmarks.py that allow each benchmark to be run in it's own server instance. This can be useful for ensuring that performance regressions/improvements aren't related to interactions between benchmarks.

@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review September 4, 2024 17:24
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about slurm run commands but this all looks good to me!

Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ajpotts ajpotts added this pull request to the merge queue Sep 6, 2024
Merged via the queue into Bears-R-Us:master with commit 906bdb2 Sep 6, 2024
10 checks passed
@jeremiah-corrado jeremiah-corrado deleted the run-isolated-benchmarks branch September 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants