Add initial implementation for Sparse Matrix Mult #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcdonald3
approved these changes
Jul 18, 2024
bmcdonald3
reviewed
Jul 18, 2024
|
The error with |
Details in PR Signed-off-by: Shreyas Khandekar <[email protected]>
Signed-off-by: Shreyas Khandekar <[email protected]>
mypy really wants the sparray type to be indexable, but that is not in the scope of this PR. I can make it the case in a future PR, but for now I would like to silence the error and move on. Therefore I added a __get_item__ method to the sparray class which just raises a NotImplementedError. Signed-off-by: Shreyas Khandekar <[email protected]>
This worked around the bug in chpldoc by not use'ing the layout enum Signed-off-by: Shreyas Khandekar <[email protected]>
ShreyasKhandekar
force-pushed
the
sparseMatrix
branch
from
5caab31 to
45183a0
Compare
bmcdonald3
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
SparseGenSymEntryandSparseSymEntryare added to support sparse matrices.sparrayis the client representation of sparse matricesak.random_sparse_matrixak.sparse_matrix_matrix_multI am not adding the new SparseMatrixMsg to ServerModule.cfg by default today because it is an unstable prototype and may change in the future.
Future work here is to add support for printing the sparrays and add a test for the new functions.