Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3510-Series.to_pandas to handle categoricals #3512

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Closes #3510-Series.to_pandas to handle categoricals #3512

merged 1 commit into from
Jul 26, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Jul 18, 2024

Closes #3510-Series.to_pandas to handle categoricals

@ajpotts ajpotts force-pushed the 3510-Series.to_pandas-to-handle-categoricals branch 3 times, most recently from a5a4da9 to a01ab52 Compare July 24, 2024 14:25
@ajpotts ajpotts marked this pull request as ready for review July 24, 2024 14:27
@ajpotts ajpotts force-pushed the 3510-Series.to_pandas-to-handle-categoricals branch from a01ab52 to 057667a Compare July 25, 2024 14:27
stress-tess
stress-tess approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I left some suggestions on the tests that are aesthetic

PROTO_tests/tests/series_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/series_test.py Show resolved Hide resolved
jaketrookman
jaketrookman approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the suggestion to make the test a little more succinct, looks good

@ajpotts ajpotts force-pushed the 3510-Series.to_pandas-to-handle-categoricals branch from 057667a to a5ac00d Compare July 26, 2024 17:13
@ajpotts ajpotts force-pushed the 3510-Series.to_pandas-to-handle-categoricals branch from 23ef5b8 to 716cfeb Compare July 26, 2024 19:18
@stress-tess stress-tess added this pull request to the merge queue Jul 26, 2024
Merged via the queue into Bears-R-Us:master with commit 1419df6 Jul 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Series.to_pandas to handle categoricals
3 participants
@ajpotts @stress-tess @jaketrookman