Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds skip configuration for multidimensional histogram test #3506

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

brandon-neth
Copy link
Collaborator

The multidimensional histogram test was failing for unknown reason on Horizon. This PR adds a skip condition so it doesn't run on Horizon.

@brandon-neth brandon-neth requested a review from bmcdonald3 July 17, 2024 18:05
Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, the machine that this is failing on is a 16-node-xc that is being phased out and won't be around for too much longer. We don't know for sure what it is exactly causing the failure, but it is not showing up in other configurations and this will help us make more sense out of nightly testing results if we don't have this sporadic failure popping up.

@stress-tess are you alright disabling this test in this specific environment for now? We should have an alternate multilocale machine with more modern hardware (and IB interconnect) online soon and if this shows up there, that will trigger the alarm bells that we need to figure this out, but this specific configuration does not. edit: well, it doesn't trigger the bells for me at least 😄

@stress-tess
Copy link
Member

For context, the machine that this is failing on is a 16-node-xc that is being phased out and won't be around for too much longer. We don't know for sure what it is exactly causing the failure, but it is not showing up in other configurations and this will help us make more sense out of nightly testing results if we don't have this sporadic failure popping up.

@stress-tess are you alright disabling this test in this specific environment for now? We should have an alternate multilocale machine with more modern hardware (and IB interconnect) online soon and if this shows up there, that will trigger the alarm bells that we need to figure this out, but this specific configuration does not. edit: well, it doesn't trigger the bells for me at least 😄

Yah that sounds good to me!

@stress-tess stress-tess added this pull request to the merge queue Jul 17, 2024
Merged via the queue into Bears-R-Us:master with commit 9b376bf Jul 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants