Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3293: Add putmask #3370

Merged
merged 10 commits into from
Jul 11, 2024
Merged

Closes #3293: Add putmask #3370

merged 10 commits into from
Jul 11, 2024

Conversation

drculhane
Copy link
Contributor

@drculhane drculhane commented Jun 28, 2024 •
edited by stress-tess
Loading

This is the putmask discussed in a recent group meeting, with the improvements we noted for making the pdarray of masked-in values the same length as the source data.

closes #3293

ajpotts
ajpotts requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think maybe we should have it work in place though, to match numpy more exactly.

arkouda/numeric.py Outdated Show resolved Hide resolved
ajpotts
ajpotts approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

jaketrookman
jaketrookman approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

stress-tess
stress-tess requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks correct to me, but I think we can get a perf boost by writing a chpl kernel to handle this

arkouda/numeric.py Show resolved Hide resolved
arkouda/numeric.py Show resolved Hide resolved
@stress-tess stress-tess mentioned this pull request Jul 11, 2024
Closed
@stress-tess stress-tess changed the title Closes 3293 putmask Closes #3293: Add putmask Jul 11, 2024
stress-tess
stress-tess reviewed Jul 11, 2024
View reviewed changes
ServerModules.cfg Outdated Show resolved Hide resolved
serverConfig.json Outdated Show resolved Hide resolved
src/ManipulationMsg.chpl Outdated Show resolved Hide resolved
stress-tess
stress-tess reviewed Jul 11, 2024
View reviewed changes
ServerModules.cfg Outdated Show resolved Hide resolved
stress-tess
stress-tess approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

jaketrookman
jaketrookman approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates

@stress-tess stress-tess added this pull request to the merge queue Jul 11, 2024
Merged via the queue into Bears-R-Us:master with commit 592c824 Jul 11, 2024
16 checks passed
@stress-tess stress-tess mentioned this pull request Sep 18, 2024
Merged
@drculhane drculhane deleted the Closes-3293-putmask branch December 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpotts ajpotts ajpotts approved these changes

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

putmask
4 participants
@drculhane @ajpotts @stress-tess @jaketrookman