Refactor MessageArgs #3358
Merged
Refactor MessageArgs #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Fix misleading indentation in serverDaemon. Remove repeated error-handling code from ServerDaemon. Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
…clude 'toScalar', 'toScalarTuple', 'toScalarList', 'toScalarArray'. Other methods were removed or "deprecated". Added 'this()' indexing to msgArgs Signed-off-by: Jeremiah Corrado <[email protected]>
…rs-R-Us#2522. Only 'efunc2Msg' was using this functionality, so put a temporary fix in place until it can be refactored Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
bmcdonald3
reviewed
Jun 26, 2024
…n the array-api 'tolist' introduced in Bears-R-Us#3242 Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
|
CI failed to install dependencies. Could someone please restart when you get a chance. |
|
Started CI again |
ajpotts
approved these changes
Jun 27, 2024
Signed-off-by: Jeremiah Corrado <[email protected]>
bmcdonald3
approved these changes
Jun 27, 2024
stress-tess
approved these changes
Jun 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thanks for the reveiws everyone! It looks like CI failed again due to dependency installation timeouts. Could someone please re-add to the merge queue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to improve the ergonomics of argument parsing:
this(key)accessor toMessageArgs, allowing things likeconst x = msgArgs["x"]getGenericTypedArrayEntryto acceptParamObjdirectly, allowing things like:getGenericTypedArrayEntry(msgArgs["name"], st)MessageArgsobjTypefield fromMessageArgsas it was only used in Efunc2 and was easily confused with the ObjType defined in serverConfig (resolves MergeObjTypeandObjectTypeenums #2522)Most of the old MessageArgs API still exists, so message handlers can be converted to use the new API over time. As an example, ManipulationMsg was converted to use the new API.
Also cleaned up IO compat modules (most of those changes were moved to #3365), leaving only symbols related to the
ioendian->endiannesschange.