Fix CSV Reading Bugs #3314
Merged
Fix CSV Reading Bugs #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files have data meant to be distributed across multiple locales therefore we have to be aware of the lower bound of the line indices to be read in. In order to do this, we skip over the lines until this lower bound is reached. Since the domains are continuous, we don't need to worry about upper bounds. Signed-off-by: Shreyas Khandekar <[email protected]>
ShreyasKhandekar
force-pushed
the
improveCSVReads
branch
from
f84b445 to
52d6576
Compare
bmcdonald3
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves failures with CSV testing in multilocale configurations where the files do not correspond to a single locale's data.
Some files have data meant to be distributed across multiple locales
therefore we have to be aware of the lower bound of the line indices to
be read in. In order to do this, we skip over the lines until this lower
bound of the intersection is reached.
Since the domains are continuous, we don't need to worry about any other bounds.