Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3252: proto test_segarray_read failure with multi-locale #3254

Conversation

stress-tess
Copy link
Member

This PR (fixes #3252) fixes an incorrect dataset name which was causing failures when ran with multiple locales

…multi-locaale

This PR (fixes Bears-R-Us#3252) fixes an incorrect dataset name which was causing failures when ran with multiple locales
@stress-tess stress-tess changed the title Closes #3252: test proto test_segarray_read failure with multi-locaale Closes #3252: test proto test_segarray_read failure with multi-locale May 30, 2024
@stress-tess stress-tess changed the title Closes #3252: test proto test_segarray_read failure with multi-locale Fixes #3252: proto test_segarray_read failure with multi-locale May 30, 2024
Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this wasn't impossible to track down!

@stress-tess stress-tess added this pull request to the merge queue May 31, 2024
Merged via the queue into Bears-R-Us:master with commit 82d6ab5 May 31, 2024
22 checks passed
@stress-tess stress-tess deleted the 3252_segarray_read_failure_proto_tests branch June 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_segarray_read failing in make test-proto for multi-locale
3 participants