Fixes #3158: Dataframe containing a Segarray .__str__() bug
#3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug This PR (closes Bears-R-Us#3158) fixes bug when printing a dataframe containing a segarray. To handle this I added an `nbytes` attribute to segarray which just wraps the underlying values. I also modified the series init to not assume that when `data` is a list that it contains 2 elements (the first being the data and the second being the index) when the `index` is provided.
jaketrookman
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #3158) fixes bug when printing a dataframe containing a segarray.
To handle this I added an
nbytesattribute to segarray which just wraps the underlying values. I also modified the series init to not assume that whendatais a list that it contains 2 elements (the first being the data and the second being the index) when theindexis provided. This actual broke_return_agg_seriesbecause it was ignoring what was being passed in as theindexkeywordIt also adds
arkouda/scipy/stats/*.pyito the.gitignorecause it was showing up in my untracked files. I'm not sure if this is necessary