Fix Parquet double reads to properly account for null values #3091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Parquet taxi cab dataset, we were hitting end of stream errors when reading in null values and this was identified by Tess in #3087.
To fix this, we switch to reading in single values in the case where nulls are allowed so that we can check the definition level before inserting a value into the Parquet array.
Potential optimizations are an
allow_nan
flag to avoid the check and then, additionally, we could modify the previous implementation by reading the definition level and values into temporary vectors and then only assign the value if the value is non-null.The reason it didnt' work before was that it was bsaed off of
batchSize
to loop over the values, but batch size doesn't actually guarantee how many values were read, due to row group intricacies.