Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array API Manipulation Function Improvements #3056

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Array API Manipulation Function Improvements #3056

merged 10 commits into from
Apr 10, 2024

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Mar 21, 2024 •
edited
Loading

Improvements to the Array API Manipulation functions module and related code:

  • add tile, unstack, and repeat implementations
  • expand/improve testing for manipulation functions
  • performance improvements for various manipulation functions
    • remove patterns that resulted in unnecessary communication with locale 0
    • add flatten/unflatten procedures that rely on bulk put/get operations instead of aggregated communication
  • implement rank-reducing indexing
    • ex: my3DArr[1, 0:5, 0:5] now returns a 2D array instead of a 3D array with a degenerate axis

@jeremiah-corrado
refactor some array manipulation commands to reduce uneeded comm with…
d96507a 
… locale 0

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
add implementation of tile, unstack, and repeat to maniputation-funct…
8d05a31 
…ions module. Implement rank-reducing indexing for ND arrays. Bug fixes and performance improvements in manipultation functions.

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix flake8, mypy and python compat errors
6e74170 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado jeremiah-corrado changed the title Array API Performance Improvements Array API Manipulation Function Improvements Mar 28, 2024
@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review March 28, 2024 18:49
jeremiah-corrado and others added 7 commits March 28, 2024 13:21
@bmcdonald3 bmcdonald3 added this pull request to the merge queue Apr 10, 2024
Merged via the queue into Bears-R-Us:master with commit 2cd6162 Apr 10, 2024
13 checks passed
@jeremiah-corrado jeremiah-corrado deleted the array-api-perf-improvements branch April 16, 2024 14:26
@jeremiah-corrado jeremiah-corrado mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcdonald3 bmcdonald3 bmcdonald3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiah-corrado @bmcdonald3