Closes #2993: Create random subfolder and foundation for generator #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerator This PR (closes Bears-R-Us#2993) adds a random subfolder, moves the random generation methods from pdarraycreation under it, and adds the foundations for a generator class. I left the function declarations in pdarraycreation and just have them call the ones in `random` to avoid breaking existing code since `randint` is very widely used. I'm fine with leaving them indefinitely or deprecating them, I don't have strong feelings either way. Future work: Right now a generator method called multiple times always gives the same answer, which doesn't match what numpy does. I think if we add a generator type to the symbol table we can solve that issue
jaketrookman
approved these changes
Feb 28, 2024
|
Also I want to note that I haven't included tests for this iteration. I plan on doing that once we add |
ajpotts
reviewed
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #2993) adds a random subfolder, moves the random generation methods from pdarraycreation under it, and adds the foundations for a generator class.
I left the function declarations in pdarraycreation and just have them call the ones in
randomto avoid breaking existing code sincerandintis very widely used. I'm fine with leaving them indefinitely or deprecating them, I don't have strong feelings either way.Future work: Right now a generator method called multiple times always gives the same answer, which doesn't match what numpy does. I think can create a generator on chpl side to solve that issue, but I think saving that for a different PR makes sense since that involves adding a generator symbol entry