Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array API stats functions #2967

Merged
merged 15 commits into from
Mar 4, 2024
Merged

Array API stats functions #2967

merged 15 commits into from
Mar 4, 2024

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Feb 12, 2024 •
edited
Loading

Implementation of the Array API Statistical Functions:

  • max
  • min
  • mean
  • std
  • var
  • prod (reduce)
  • sum (reduce)

And the two searching functions that were already implemented for 1D arrays:

  • argmin
  • argmax

Also adds multidimensional indexing assignments:

a[2, :, 8] = 3.14

@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review February 13, 2024 23:28
jeremiah-corrado and others added 13 commits February 15, 2024 09:46
@jeremiah-corrado
Merge branch 'master' into array-api-stats-functions
96a2422
@jeremiah-corrado
fix ambiguity error
d0630b6 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix test failures and add docs to new backend procedures
17add9e 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'master' into array-api-stats-functions
a702697
@jeremiah-corrado
fix flake8 errors
f01703a 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'array-api-stats-functions' of github.com:jeremiah-corra…
0ae84f9 
…do/arkouda into array-api-stats-functions
@jeremiah-corrado
fix std command
9b995e1 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix 'all' reduction
0c855f4 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
add support for ND assignment indexing. Start adding tests for array-…
40622a4 
…api stats functions

Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
bug fixes and new tests for searching and stats functions
794405c 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
fix array_view test
5ca037c 
Signed-off-by: Jeremiah Corrado <[email protected]>
@jeremiah-corrado
Merge branch 'master' into array-api-stats-functions
83ef5a6
@jeremiah-corrado
Merge branch 'master' into array-api-stats-functions
a7e9302
bmcdonald3
bmcdonald3 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much all my feedback is maybe replace those otherwise halt paths with return new MsgTuple(errorMsg, MsgType.ERROR);, rest looks good, nice work.

arkouda/pdarrayclass.py Show resolved Hide resolved
src/ReductionMsg.chpl Show resolved Hide resolved
@bmcdonald3 bmcdonald3 added this pull request to the merge queue Mar 4, 2024
Merged via the queue into Bears-R-Us:master with commit f395c22 Mar 4, 2024
13 checks passed
@jeremiah-corrado jeremiah-corrado deleted the array-api-stats-functions branch March 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcdonald3 bmcdonald3 bmcdonald3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiah-corrado @bmcdonald3