Closes #2937 : Fix string read bug for large Parquet files #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the size of the number of rows in a parquet string column exceeds the batch size, this can sometimes give incorrect results since the readBatch function utilizes the definition level in a unique way as opposed to other types, causing false positives for whether or not a string was read. In order to resolve this, I am reverting the batch size reading, which will reduce performance, but since we are planning on reworking string reads anyway, this isn't that big of a loss.
jeremiah-corrado
approved these changes
Jan 31, 2024
stress-tess
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the size of the number of rows in a parquet string column exceeds the batch size, this can sometimes give incorrect results since the readBatch function utilizes the definition level in a unique way as opposed to other types, causing false positives for whether or not a string was read. In order to resolve this, I am reverting the batch size reading, which will reduce performance, but since we are planning on reworking string reads anyway, this isn't that big of a loss.
Closes #2937