Array API manipulation functions #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremiah Corrado <[email protected]>
…ionMsg.chpl Signed-off-by: Jeremiah Corrado <[email protected]>
…ionMsg.chpl Signed-off-by: Jeremiah Corrado <[email protected]>
…ntiation in parseServerConfig.py Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
bmcdonald3
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Not sure I have a ton of feedback, I think the API answering the qeustions of design have those bases covered and the tests look good, so since we are focused on correctness and not performance off the bat, I think this looks good.
I am curious about a few things I mentioned and one other thing I'll say is the amount of param for loops we have is unfortunate, but I understand we need those because of how we are doing the dimensionality, that just really jumped out at me taking a pass over the code.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Array API manipulation functions
Adds implementations of:
concatexpand_dimsflippermute_dimsreshaperollsqueezestackLike broadcasting,
reshapeandsqueezeboth create arrays whose rank can/will be different than the array being operated on. As such, these procedures also get compiled for various pairs of supported ranks, which required some modifications toparseServerConfig.pyTests are added for each of the new functions.
Adds a separate Array API module config file with modules that are only needed for the ArrayAPI.