Replace use of binary 'or' with logical 'or'

[DanilaFe]

A recent Chapel PR (chapel-lang/chapel#24155) disallowed the use of expressions like a < b < c because of its confusing meaning. Specifically, a < b < c is not equivalent to a < b && b < c. Instead, the above expression is equivalent to (a < b) < c, which is likely not what the author intended. On main, Chapel requires explicit parentheses: (a < b) < c or a < (b < c).

This led to us uncovering some bugs that have to do with the use of binary OR | instead of the logical or ||. Notably, the the precedence for these operators is as follows: | > > > ||. Thus, a < b | c parses as a < (b | c), whereas a < b || c parses as (a < b) || c. This is significant in conditionals, such as those affected by the PR:

if xiBin < 0 | yiBin < 0 | (xiBin > (numXBins-1)) | (yiBin > (numYBins-1)) { /* ... */ }
//         ^^^^^^^^^ probably not what you want!
//                   Equivalent to:
if xiBin < (0 | yiBin) < (0 | (xiBin > (numXBins-1)) | (yiBin > (numYBins-1))) { /* ... */ }

As you can see, this was previously being interpreted as the ternary .. < .. < .. expression. This is both likely incorrect logically (I doubt the intention is to compare xiBin against yiBin or'ed with zero) and, on the main branch of the Chapel compiler, incorrect syntactically.

This PR fixes the syntax error caused by this issue, and updates the uses of the bitiwse | operator to be uses of the logical ||.

[bmcdonald3]

Looks good, thanks Daniel!