Closes #2901: Fix performance regression due to setting ndim field in sym entry #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m field in sym entry In Bears-R-Us#2865, the `ndim` field was being set after `init this`, which was resulting in a performance hit for multi locale runs. Commenting that line out for now to restore the performance, since it is only used in currently experimental features. Scan benchmark on 2 locales of an XC: | before | this PR | | ----------- | ----------- | | 42.86 GiB/s | 68.50 GiB/s | Closes Bears-R-Us#2901
stress-tess
changed the title
stress-tess
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2865, the
ndimfield was being set afterinit this, which was resulting in a performance hit for multi locale runs. Commenting that line out for now to restore the performance, since it is only used in currently experimental features.Scan benchmark on 2 locales of an XC:
Closes #2901