-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make arkouda server configurable w.r.t. supported types #2876
Make arkouda server configurable w.r.t. supported types #2876
Conversation
…ecifying supported scalar types Signed-off-by: Jeremiah Corrado <[email protected]>
…ept. Modify dtypes.py to reflect additional types. Signed-off-by: Jeremiah Corrado <[email protected]>
…, 'create10' Signed-off-by: Jeremiah Corrado <[email protected]>
…usedModulesFmt=json' Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
…patability with arkouda-contrib Signed-off-by: Jeremiah Corrado <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Sorry for the delay in reviewing
Do you mind providing your compilation times on master and with this PR just as a quick check that compilation times don't seem to go up
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
@pierce314159, I had to make some changes to With that change, the compilation times look about the same on my machine when compared with the master branch for the llvm and clang backends:
llvm - master...
clang - master...
llvm - this branch...
clang - this branch...
|
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
Signed-off-by: Jeremiah Corrado <[email protected]>
… Fix syntax errors Signed-off-by: Jeremiah Corrado <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of comments that you don't necessarily need to address, just things to think about.
Signed-off-by: Jeremiah Corrado <[email protected]>
Adds a new
serverConfig.json
file that contains options for specifying maximum array dimensionality (from #2829), as well as some new options to specify which scalar types should be supported by the server.With the new options in place, Arkouda will be able to improve its array_api compliance, where all of numpy's scalar data types are to be supported. This will also allow us to improve the "Arkouda as a numpy drop-in replacement" story when the server is compiled to support all the scalar types. When support for a given type is not desired, it will be ignored at compile time (using some
config param
values), leading to faster compilation and a smaller binary.Other improvements:
randIntMsg
,castMsg
,createMsg
, andsetMsg
procedures will now support all the numpy scalar types. This was implement as a proof-of-concept, with the intention of incrementally expanding type-configurability support in later PRs