Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Chapel 1.30 #2844

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Conversation

brandon-neth
Copy link
Collaborator

Removes the 1.30 compatibility modules. Four of the compatibility modules for the supported versions were empty modules present for the sake of resolving use statements. I removed those modules and their uses as well: ArkoudaArrayCompat, ArkoudaBitOpsCompat, ArkoudaListCompat, and ArkoudaStringBytesCompat.

@brandon-neth
Copy link
Collaborator Author

Also updated the workflows to use 1.32 and 1.31 rather than 1.31 and 1.30.

@stress-tess stress-tess marked this pull request as draft November 7, 2023 17:37
Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Brandon 🎉

jaketrookman
jaketrookman previously approved these changes Nov 7, 2023
@jaketrookman jaketrookman dismissed their stale review November 7, 2023 18:57

Waiting for Pierce's confirmation before moving forward

@stress-tess stress-tess marked this pull request as ready for review November 7, 2023 19:03
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Brandon

@stress-tess stress-tess enabled auto-merge November 7, 2023 19:09
@stress-tess stress-tess added this pull request to the merge queue Nov 7, 2023
Merged via the queue into Bears-R-Us:master with commit 1af3785 Nov 7, 2023
@brandon-neth brandon-neth deleted the drop1-30 branch November 7, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants