Fix a Makefile conditional to test for empty string instead of 'none' #2841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hitting an issue where, due to not having CHPL_HOME set, CHPL_CXX was being set to the empty string and the 'make compile-arrow-cpp' step would fail as follows due to not having a C++ compiler specified (I'm still not sure where the '-' on the '-O3' option went...):
The conditional that was designed to guard against this is the following:
but this didn't fire because CHPL_CXX wasn't unset, it was simply set to the empty string. Here, I've changed the logic to:
to test for the empty string, which causes CXX to be set to g++ as intended.