Closes #2794: Fix distributed makeDistArray call for Chapel 1.30 and 1.31 #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the compatability modules, one of the `makeDistArray` calls had a `domain(1)`, which is treated as a default rectangular array, meaning that block arrays cannot be passed to the function. Removing the `(1)` and getting it back to a generic domain fixes this issue.
stress-tess
requested review from
stress-tess,
jaketrookman and
TheOddCzar789
stress-tess
approved these changes
Sep 29, 2023
TheOddCzar789
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the compatability modules for 1.30 and 1.31, one of the
makeDistArraycalls had adomain(1), which is treated as a default rectangular array, meaning that block arrays cannot be passed to the function. Removing the(1)and getting it back to a generic domain fixes this issue.Closes #2794