Closes #2679: Convert check for re2 in the compiler from a .compile() method to new regex()
#2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… regex()
In Chapel 1.30, regex.compile() was deprecated in favor of new regex(),
however the program that verifies that regex is enabled in Arkouda
wasn't updated, so was still relying on this routine. We removed the
routine tonight and broke our smoke tests, not realizing this. Here,
I've updated the test to use 'new regex()' instead.
jaketrookman
approved these changes
Sep 15, 2023
stress-tess
changed the title
.compile() method to new regex().compile() method to new regex()
stress-tess
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chapel 1.30, regex.compile() was deprecated in favor of new regex(), however the program that verifies that regex is enabled in Arkouda wasn't updated, so was still relying on this routine. We removed the routine tonight and broke our smoke tests, not realizing this. Here, I've updated the test to use 'new regex()' instead.
Helps with https://github.com/Cray/chapel-private/issues/5406, though we may want to restore the dependency checks once this is merged.
Close #2679