Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2768: Verify that all test files pass flake8 #2769

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

jaketrookman
Copy link
Contributor

This PR (Close #2768) goes back through all the newly converted tests and ensuring that flake8 passes, mostly fixing comments. Also removing a few old extraneous returns.

Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing some flake8 errors not addressed here. I'm guessing that I have a later version of flake8

PROTO_tests/tests/datetime_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/groupby_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/operator_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/stats_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/message_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/string_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/string_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/symbol_table_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/operator_test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@TheOddCzar789 TheOddCzar789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that isort suggests changes on a handful of files. Is that worth fixing here or should it be another ticket?

@stress-tess stress-tess added this pull request to the merge queue Sep 20, 2023
Merged via the queue into Bears-R-Us:master with commit 6651b27 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that all test files pass flake8. Correct any that do not.
3 participants