Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2744 - Implement skew and hist_all #2756

Merged
merged 10 commits into from
Sep 12, 2023

Conversation

egelberg
Copy link
Contributor

@egelberg egelberg commented Sep 7, 2023

Added the two following methods to arkouda:

skew

Computes the sample skewness of an array (added to pdarrayclass.py). Based on scipy.stats.skew

  • Skewness > 0 means there's greater weight in the right tail of the distribution.
  • Skewness < 0 means there's greater weight in the left tail of the distribution.
  • Skewness == 0 means the data is normally distributed.

hist_all

Creates a grid plot histogramming all numeric columns in ak dataframe.

import arkouda as ak
from arkouda.plotting import hist_all 
ak_df = ak.DataFrame({"a": ak.array(np.random.randn(100)),
                      "b": ak.array(np.random.randn(100)),
                      "c": ak.array(np.random.randn(100)),
                      "d": ak.array(np.random.randn(100))
                     })
hist_all(ak_df)

PNG image

@stress-tess stress-tess changed the title init commit Closes #2744 - Implement skew and hist_all Sep 8, 2023
@stress-tess stress-tess linked an issue Sep 8, 2023 that may be closed by this pull request
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, mostly style stuff but I'm seeing one error in hist_all

arkouda/pdarrayclass.py Outdated Show resolved Hide resolved
arkouda/pdarrayclass.py Outdated Show resolved Hide resolved
arkouda/plotting.py Outdated Show resolved Hide resolved
arkouda/plotting.py Outdated Show resolved Hide resolved
arkouda/plotting.py Outdated Show resolved Hide resolved
arkouda/plotting.py Outdated Show resolved Hide resolved
arkouda/plotting.py Show resolved Hide resolved
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the aforementioned changes, looks good

@TheOddCzar789 TheOddCzar789 self-requested a review September 11, 2023 18:52
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the log argument

arkouda/plotting.py Show resolved Hide resolved
@stress-tess stress-tess added this pull request to the merge queue Sep 12, 2023
Merged via the queue into Bears-R-Us:master with commit 5fa1e52 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement skew and hist_all
4 participants