Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ServerStatusDaemon #2674

Merged
merged 10 commits into from
Aug 18, 2023
Merged

implement ServerStatusDaemon #2674

merged 10 commits into from
Aug 18, 2023
+171 −19

Conversation

hokiegeek2
Copy link
Contributor

@hokiegeek2 hokiegeek2 commented Aug 15, 2023 •
edited by stress-tess
Loading

Closes #2658 and closes #2575

This PR does the following:

  1. implements a liveness/readiness probe in the form of the ServerStatusDaemon
  2. adds OS checking for MemoryMgmt module which only works on Linux and Unix systems
  3. adds/updates README content and Chapel doc comments

jaketrookman
jaketrookman approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Ethan-DeBandi99
Ethan-DeBandi99 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Single quick verification (more of a sanity check).

README.md Show resolved Hide resolved
stress-tess
stress-tess approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few super small comments all just formatting and one typo

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stress-tess stress-tess added this pull request to the merge queue Aug 18, 2023
Merged via the queue into Bears-R-Us:master with commit 6d1454b Aug 18, 2023
@hokiegeek2 hokiegeek2 deleted the 2658_implement_StatusServerDaemon branch March 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-DeBandi99 Ethan-DeBandi99 Ethan-DeBandi99 approved these changes

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@TheOddCzar789 TheOddCzar789 TheOddCzar789 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement StatusServerDaemon improve memory management documentation
5 participants
@hokiegeek2 @Ethan-DeBandi99 @stress-tess @jaketrookman @TheOddCzar789