Closes #2672, #2662 - Update CommPrimitives functions and precision in test_str_repr
#2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace the use of primitives chpl_comm_get and chpl_comm_put with usage of the Communications module. This fixes problems uncovered by chapel-lang/chapel#22884.
* adds an expected answer that includes the improved precision for whole numbers printed as reals, as corrected by Chapel PR chapel-lang/chapel#22924
arezaii
changed the title
stress-tess
requested review from
Ethan-DeBandi99,
bmcdonald3,
stress-tess and
ronawho
stress-tess
changed the title
functions and precision in test_str_repr`
stress-tess
changed the title
functions and precision in test_str_repr`CommPrimitives functions and precision in test_str_repr
bmcdonald3
approved these changes
Aug 15, 2023
ronawho
approved these changes
Aug 16, 2023
jaketrookman
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2672 by replacing the use of Chapel
__primitivecalls for performing bulkget/putoperations with calls to the ChapelCommunicationmodule, introduced in Chapel 1.28.This change is only for backend calls to
PUTandGET, and should have no effect on any Arkouda interface.While here, also updated the expected results in
operator_tests::test_str_reprto resolve #2662.TESTING:
Reviewer should note:
(also removed a bunch of trailing spaces)