Fixes #2617: Bug in comparison of segarrays containing empty segments #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stress-tess
requested review from
Ethan-DeBandi99,
jaketrookman and
TheOddCzar789
added 2 commits
August 7, 2023 12:15
…y segments This PR (fixes Bears-R-Us#2617): - Fixes bug in equality check of segarays containing empty segments. Due to bug in gen_ranges, not using the `selfcmp` groupby, and size mismatch since segarr.all() excludes empty segs - Fixed issue with empty segs in gen_ranges - Added support for indexing segarray with a uint pdarray - Fixed error message in indexing and dataframe indexing - Added tests for seggarray comparisons
stress-tess
force-pushed
the
2617_comparison_segarray_empty_seg_bug
branch
from
2aa24e0 to
f5864a1
Compare
TheOddCzar789
approved these changes
Aug 9, 2023
Ethan-DeBandi99
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (fixes #2617):
selfcmpgroupby, and size mismatch sincesegarr.all()excludes empty segsgen_ranges