Closes #2581 - Strings.get_null_indicies Not Reporting Correct Results in Parquet
#2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-DeBandi99
requested review from
stress-tess,
jaketrookman and
TheOddCzar789
stress-tess
approved these changes
Jul 17, 2023
jaketrookman
approved these changes
Jul 17, 2023
TheOddCzar789
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2581
This PR updates the workflow for writing Strings objects to Parquet. Previously, even empty string segments were being written with a
definition level=1. This results in the read of those segments showingvalues_read=1, but the length of the value is 0. Becausevalues_read=1was being seen, the null indicies were not being set properly. In order to get thevalues_read=0as expected, during the write workflow a check of the value length was added. If this is 0, then thedefinition levelis updated to 0. I verified with the test provided by @pierce314159 that this is now functioning as expected in the existing test and the updated test that was provided.