Closes #2559 - dataframe_test.py conversion for new framework
#2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-DeBandi99
requested review from
stress-tess,
jaketrookman and
TheOddCzar789
TheOddCzar789
approved these changes
Jul 18, 2023
stress-tess
requested changes
Jul 18, 2023
Ethan-DeBandi99
requested review from
stress-tess,
jaketrookman and
TheOddCzar789
stress-tess
reviewed
Jul 19, 2023
|
@pierce314159 - I believe I addressed everything, but please let me know if I missed something. |
…nd possible simplications.
…updates pdarray creation to detect numpy.object_ with str elements.
Ethan-DeBandi99
force-pushed
the
2559_dataframe_test_upd
branch
from
61d513f to
169f0d0
Compare
stress-tess
reviewed
Jul 20, 2023
stress-tess
reviewed
Jul 20, 2023
jaketrookman
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2559
Updates the existing
dataframe_test.pyto function within the new test framework. Specific test forto_pandaswas removed because this functionality is used in the majority of tests and does not require testing on its own. There is not a lot of parameterization here as I believe the cases we are dealing with are fairly representative. We may want to add additional general case testing in the future, but should not be required here.This PR also adds a
to_listmethod toak.Seriesfor use within test validation.This PR updates
ak.arrayto check the first element of anndarrayif itsdtype=numpy.object_. This case can also occur withBigIntso we need to determine if the elements are strings or not for processing. This required a simple modification to anifblock. I validated that all existing test cases pass with this modification as well.