Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2570: bigint_agg_test.py Conversion for new test framework #2578

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Closes #2570: bigint_agg_test.py Conversion for new test framework #2578

merged 4 commits into from
Jul 19, 2023
+61 −0

Conversation

TheOddCzar789
Copy link
Contributor

This PR (Closes #2570):

  • Converts file to new test framework by adding pytest

jaketrookman
jaketrookman requested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth making SIZE an array of values and parameterizing it to allow for easier updates for future implementation.

Ethan-DeBandi99
Ethan-DeBandi99 reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Added one recommendation for moving a function, but otherwise agree with previous comments and the changes made on those fronts.

PROTO_tests/tests/bigint_agg_test.py Outdated Show resolved Hide resolved
stress-tess
stress-tess approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, but this looks mostly good to go to me. Nice work!

PROTO_tests/tests/bigint_agg_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/bigint_agg_test.py Outdated Show resolved Hide resolved
@TheOddCzar789 TheOddCzar789 changed the title Closes #2570: bigint_agg_test.py Conversion for new test framework Closes #2570: bigint_agg_test.py Conversion for new test framework Jul 19, 2023
jaketrookman
jaketrookman approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

stress-tess
stress-tess approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stress-tess stress-tess added this pull request to the merge queue Jul 19, 2023
Merged via the queue into Bears-R-Us:master with commit 5b4ea50 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@Ethan-DeBandi99 Ethan-DeBandi99 Awaiting requested review from Ethan-DeBandi99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigint_agg_test.py Conversion for new test framework
4 participants
@TheOddCzar789 @Ethan-DeBandi99 @stress-tess @jaketrookman