Closes #2536: alignment_test.py Conversion for new test framework
#2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOddCzar789
requested review from
Ethan-DeBandi99,
stress-tess and
jaketrookman
stress-tess
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Overall looks good. There are 2 spots it looks like we are doing the same generation to set up the test. I think it would be best to pull this out into a helper function and call it in both locations. Also, I think we need to add an issue for other work to complete on this later.
stress-tess
reviewed
Jul 18, 2023
jaketrookman
approved these changes
Jul 18, 2023
TheOddCzar789
changed the title
alignment_test.py Conversion for new test framework
jaketrookman
approved these changes
Jul 19, 2023
Ethan-DeBandi99
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (Closes #2536):