Closes #2560 - Fixes Missing empty segments for parquet read of segarray with string values #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngle SegArray with Strings values.
Ethan-DeBandi99
requested review from
stress-tess,
jaketrookman and
TheOddCzar789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2560
This issue resulted from the Strings case within SegArray's write workflow not properly handling empty segments. Thus, it only wrote segments with
length>0. I added the check for 0 length segments and handling to write the empty segment into the Parquet file.I also added a test using the example provided in the issue to ensure functionality.