Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2542 - message_test.py Conversion for new test framework #2544

Merged

Conversation

Ethan-DeBandi99
Copy link
Contributor

Closes #2542

Configures message_test.py for the new test framework.

Updates the argument testing to add a bit of coverage. The tests are restructured to ensure that the arg conversion to a string that is expected by the message processing is checking the string and not doing any other modifications/alteration to test accuracy.

Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! couple small comments but only thing that needs to be done is removing commented out line

PROTO_tests/tests/message_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/message_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/message_test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Pierce's comments, everything else looks good

Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

PROTO_tests/tests/message_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/message_test.py Show resolved Hide resolved
PROTO_tests/tests/message_test.py Show resolved Hide resolved
@stress-tess stress-tess enabled auto-merge July 6, 2023 20:39
@stress-tess stress-tess added this pull request to the merge queue Jul 6, 2023
Merged via the queue into Bears-R-Us:master with commit 43955a9 Jul 6, 2023
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 2542_message_test_upd branch July 7, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message_test.py Conversion for new test framework
4 participants