-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2542 - message_test.py
Conversion for new test framework
#2544
Closes #2542 - message_test.py
Conversion for new test framework
#2544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! couple small comments but only thing that needs to be done is removing commented out line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides Pierce's comments, everything else looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Co-authored-by: pierce <[email protected]>
Closes #2542
Configures
message_test.py
for the new test framework.Updates the argument testing to add a bit of coverage. The tests are restructured to ensure that the arg conversion to a string that is expected by the message processing is checking the string and not doing any other modifications/alteration to test accuracy.