Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2524 extend arkouda client to enable alternative channel implementations #2525

Merged
merged 2 commits into from
Jun 26, 2023
Merged

2524 extend arkouda client to enable alternative channel implementations #2525

merged 2 commits into from
Jun 26, 2023

Conversation

hokiegeek2
Copy link
Contributor

Closes #2524

@hokiegeek2
Copy link
Contributor Author

this demonstrates both the ZmqChannel and GrpcChannel-configured clients connecting to arkouda_server and arkouda_proxy_server, respectively:

image

stress-tess
stress-tess approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Ethan-DeBandi99
Ethan-DeBandi99 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ethan-DeBandi99 Ethan-DeBandi99 added this pull request to the merge queue Jun 26, 2023
@hokiegeek2
Copy link
Contributor Author

hokiegeek2 commented Jun 26, 2023 •
edited
Loading

@Ethan-DeBandi99 @pierce314159 thanks guys -> key thing here is the only difference is ADDING the ability to pass in a channel, NOT changing any Channel functionality or connect/send_string_message functionality using Channels.

Merged via the queue into Bears-R-Us:master with commit b066555 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@Ethan-DeBandi99 Ethan-DeBandi99 Ethan-DeBandi99 approved these changes

@jaketrookman jaketrookman Awaiting requested review from jaketrookman

@TheOddCzar789 TheOddCzar789 Awaiting requested review from TheOddCzar789

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Arkouda client to enable alternative Channel implementations
3 participants
@hokiegeek2 @Ethan-DeBandi99 @stress-tess