Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace c_memcpy with OS.POSIX.memcpy in CommAggregation module #2517

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Replace c_memcpy with OS.POSIX.memcpy in CommAggregation module #2517

merged 3 commits into from
Jun 20, 2023

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Jun 20, 2023 •
edited
Loading

Replace uses of c_memcpy with memcpy in CommAggregation module.

Resolves #2518

bmcdonald3
bmcdonald3 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this!

@stress-tess stress-tess mentioned this pull request Jun 20, 2023
Closed
@stress-tess stress-tess added this pull request to the merge queue Jun 20, 2023
Merged via the queue into Bears-R-Us:master with commit 2034dcb Jun 20, 2023
@jeremiah-corrado jeremiah-corrado deleted the c_memcpy-comm-agg-updates branch June 22, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman approved these changes

@stress-tess stress-tess stress-tess approved these changes

@bmcdonald3 bmcdonald3 bmcdonald3 approved these changes

@Ethan-DeBandi99 Ethan-DeBandi99 Awaiting requested review from Ethan-DeBandi99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated c_memcpy procedure is used in the CommAggregation module
4 participants
@jeremiah-corrado @bmcdonald3 @stress-tess @jaketrookman