Switch to C++17 for Arrow compilation #1858
Conversation
Previously, we were building Arrow with -std=c++11, but now Arrow is using features that require C++17, so this PR updates that compilation flag.
|
The Arrow pre-release for 10.0.0 came out today and it now requires C++17 and our CI was getting that latest version, which apparently includes pre-releases. After chatting with Ethan, we decided it is probably best to have the CI be using the We want to keep up to date with the new releases, but figure we will just hardcode the release for now, since Arkouda is already doing that for a number of other dependencies. Chapel requires GCC 7+, which supports the majority of C++17 features, so Elliot thought it wouldn't be the end of the world to use C++17 in the Arkouda build, so if we end up wanting to support the new Arrow versions, that probably won't cause any issues, but I think we are going to defer that for now. |
The Arrow pre-release for 10.0.0 came out today and it now requires C++17 and our CI was getting that latest version, which apparently includes pre-releases.
After chatting with Ethan and Pierce, we decided it is probably best to have the CI be using the
make install-arrowcommand that is in the Makefile so the CI is installing in the same way that a user would be on their machine, rather than the specific install of getting the latest that it is using today.We want to keep up to date with the new releases, but figure we will just hardcode the release for now, since Arkouda is already doing that for a number of other dependencies.
Chapel requires GCC 7+, which supports the majority of C++17 features, so Elliot thought it wouldn't be the end of the world to use C++17 in the Arkouda build, so if we end up wanting to support the new Arrow versions, that probably won't cause any issues, but I think we are going to defer that for now.