Fix Chapel version query #1823
Merged
Fix Chapel version query #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 1.28 and prior, the `chplVersion` string is prefixed with "version", but that has been removed since, so this string split was resulting in an empty array, meaning that the index into the array was out of bounds. This PR just does a replace on the string for "version ", so it works both for the old string that contained "version " and the new string that does not.
bmcdonald3
force-pushed
the
chpl-version
branch
from
47cedd8 to
ccea49c
Compare
hokiegeek2
approved these changes
Oct 4, 2022
stress-tess
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.28 and prior, the
chplVersionstring is prefixed with "version", but that has been removed since, so this string split was resulting in an empty array, meaning that the index into the array was out of bounds.This PR just does a replace on the string for "version ", so it works both for the old string that contained "version " and the new string that does not.