Closes #1792 - GroupBy Symbol Table Entry
#1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-DeBandi99
requested review from
reuster986,
stress-tess,
mhmerrill and
joshmarshall1
|
Converting to draft until I resolve the bug in gasnet. Also, realized I forgot to merge in updates to master and will do that as well. |
Ethan-DeBandi99
force-pushed
the
1792_groupbysymentry
branch
from
40424c8 to
7579cbc
Compare
|
Adding a note that #1807 is needed before merging this. |
Ethan-DeBandi99
force-pushed
the
1792_groupbysymentry
branch
from
c29dec9 to
9d2bcc2
Compare
Ethan-DeBandi99
force-pushed
the
1792_groupbysymentry
branch
from
9d2bcc2 to
3d09d05
Compare
joshmarshall1
approved these changes
Oct 11, 2022
…will be updated in the future to remove the dtype storage requirement. Currently only configured to build the GroupBy object from keys. Providing all elements is still fully client side, but will be moved in the future.
…ul on the CI. Correcting and repushing.
Ethan-DeBandi99
force-pushed
the
1792_groupbysymentry
branch
from
fd779bc to
ef7915e
Compare
stress-tess
reviewed
Oct 13, 2022
stress-tess
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1792
GroupByobjects. These are only created currently in the case whenkeysis provided. If all elements are provided, the object remains client side. IssueGroupByCreationfrom_parts#1803 addresses adding support creation from all components.GroupBySymEntryinherits fromGenSymEntryin preparation for removingCompositeSymEntry.CompositeSymEntrycurrently does not add any information that is not found inGenSymEntryand does not appear necessary.GroupByobject.createGroupBymessage.unique_keysproperty is not stored on the server. IssueGroupBy.unique_keysServer Side Computation #1804 will address computing Unique Keys on the server.This code utilizes components of
Unique, but does not require the full workflow at this time.