Closes #1689 - Adds support for DataFrame to generic attach #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmarshall1
requested review from
Ethan-DeBandi99,
stress-tess and
mhmerrill
Ethan-DeBandi99
suggested changes
Sep 29, 2022
joshmarshall1
force-pushed
the
1689_dataframe_generic_attach
branch
from
b6ff525 to
1471da0
Compare
Ethan-DeBandi99
approved these changes
Sep 29, 2022
stress-tess
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1689
On the chapel side, the symbol table proc
findAllhas been modified to return the matching portion of the regex instead of the entire string that was searched. This allows for more flexibility in searches. The DataFrame attach proc uses the existing attach processes for Strings, pdarray, Categorical, and SegArray to build it's return message.On the python side the function from_return_msg has been added to DataFrame as well as a helper function that is used to parse the column name out of the registry entry name.