Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add getChplVersion/chplVersion to ServerConfig and chplVersion splash message #1741

Merged
merged 1 commit into from
Sep 6, 2022
Merged

add getChplVersion/chplVersion to ServerConfig and chplVersion splash message #1741

merged 1 commit into from
Sep 6, 2022

Conversation

hokiegeek2
Copy link
Contributor

This PR addresses #1650

Ethan-DeBandi99
Ethan-DeBandi99 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't realize a Version module existed. This is pretty cool and I think will be a huge help for debugging.

@pierce314159, @mhmerrill - would you be on board with adding an issue to update CONTRIBUTING.md to request that this output be included in bug tickets? In some instances I believe this would be extremely helpful.

@mhmerrill
Copy link
Contributor

Looks good. I didn't realize a Version module existed. This is pretty cool and I think will be a huge help for debugging.

@pierce314159, @mhmerrill - would you be on board with adding an issue to update CONTRIBUTING.md to request that this output be included in bug tickets? In some instances I believe this would be extremely helpful.

i would support the inclusion of this in CONTRIBUTING.md, also maybe we should include this info in the arkouda.client.get_config().

@stress-tess stress-tess merged commit 19a7700 into Bears-R-Us:master Sep 6, 2022
@hokiegeek2 hokiegeek2 mentioned this pull request Sep 6, 2022
Closed
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this pull request Sep 6, 2022
Closed
@hokiegeek2 hokiegeek2 deleted the 1650_add_chapel_version_to_ServerConfig branch September 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@Ethan-DeBandi99 Ethan-DeBandi99 Ethan-DeBandi99 approved these changes

@mhmerrill mhmerrill Awaiting requested review from mhmerrill

@joshmarshall1 joshmarshall1 Awaiting requested review from joshmarshall1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hokiegeek2 @mhmerrill @Ethan-DeBandi99 @stress-tess