Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #1709 - FindSegmentsMsg.chpl JSON Message Arguments #1714

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Closes #1709 - FindSegmentsMsg.chpl JSON Message Arguments #1714

merged 3 commits into from
Aug 31, 2022

Conversation

Ethan-DeBandi99
Copy link
Contributor

Closes #1709
Part of #1616

Updating FindSegments.chpl to use JSON message arguments in place of string arguments.

stress-tess
stress-tess approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where we ever use this since there doesn't seem to be a client side "findSegments" command. I think there's one extra line that can be removed, but i don't see any issue with the JSONification of the arguments

src/FindSegmentsMsg.chpl Outdated Show resolved Hide resolved
joshmarshall1
joshmarshall1 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@joshmarshall1 joshmarshall1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from what Pierce already pointed out, looks good

@stress-tess stress-tess merged commit 79c8ce5 into Bears-R-Us:master Aug 31, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 1709_findsegs_json_v2 branch August 31, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@joshmarshall1 joshmarshall1 joshmarshall1 approved these changes

@mhmerrill mhmerrill Awaiting requested review from mhmerrill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FindSegmentsMsg.chpl JSON Message Arguments
3 participants
@Ethan-DeBandi99 @stress-tess @joshmarshall1