Closes #1632 - Multiple dtype support and improved list processing
#1662
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects. Updated parsing to require objects in the list be the same type, though pdarray dtypes are able to have varying dtypes. Added testing for the _json_args_to_str. Ensure that numeric, str, Strings, and pdarray are properly converted for parsing on the server.
joshmarshall1
approved these changes
Aug 5, 2022
stress-tess
reviewed
Aug 5, 2022
stress-tess
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1632
dtypeis now set to the type of the value within the list. This allows for a list ofpdarrays that contain differentdtypesto be in the same list. This does still require the list to be made up of 1 type.Note - The regexes in the test are not using the escape sequences
\wor\dbecause pytest produces deprecation warnings when using them