-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arkouda_server refactor with external integration #1602
arkouda_server refactor with external integration #1602
Conversation
…erver_refactor_external_integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. For clarity, it would probably be worthwhile documenting why this PR is separate from the standard refactor. The reasoning was clear after we spoke, but it would be good to document.
Posting as comment since this is still a draft
…erver_refactor_external_integration
…eregister with Kubernetes
….com:hokiegeek2/arkouda into arkouda_server_refactor_external_integration
… locic, added CLI param for deployment type, refined README
…erver_refactor_external_integration
…ntegration module
@mhmerrill @reuster986 @pierce314159 @Ethan-DeBandi99 @joshmarshall1 this is now ready for review. I merged in the final arkouda_server-ServerDaemon refactor, consolidated all register/deregister logic in the ExternalIntegration module and added a EXTERNAL_INTEGRATION.md file linked to the main README.md detailing how things work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to go.
This PR basically extends the arkouda_server_refactor PR that was merged last week, encapsulating logic to register Arkouda with external systems--in this PR, specifically as a Kubernetes service) upon Arkouda startup and deregister Arkouda from Kubernetes upon receipt of the ak.shutdown() client request.
This PR consists of the following: